24.146.215.113 at 04:43, 10 November 2014

2014-11-10T04:43:38Z

Xaizek: Initial version of the page

2014-07-28T17:06:09Z

Initial version of the page

New page

Changes might be proposed as pull requests on GitHub or sent as patches in an
e-mail or attached to a ticket. This page gives some advices for the later
cases.

==== Advices on patch files ====

When providing a patch please as a diff please consider the following (these are
not strict rules, but it makes reviewing easier):
# Use unified diff format. See [[#Why_unified_diff|section below]] for reasons.
# Make patch in root directory of the source tree.
# Give them meaningful names.
# Attach patches when possible instead of providing them in body of an e-mail or in description of a ticket. Automatic text formatting can make it unreadable or even make it impossible to apply.
# (optional) How would you like to be credited, e.g. maybe real name or nick name only.

==== Making a patch ====

From <code>git</code> repository:
* Uncommited:
git diff > change-description.patch
* Commited:
git format-patch -1

From unarchived sources:
patch --unified src/old-version.c src/new-version.c > change-description.patch

==== Why unified diff ====

Unified diff is more human readable. See example below.

Non-unified diff format:

<source lang="diff">
$ diff src/utils/utils_nix.c_ src/utils/utils_nix.c
156,162c156
< while(select(fd + 1, &read_ready, NULL, NULL, &ts) == 0);
<
< /* Inform other parts of the application that cancellation took place. */
< if(errno == EINTR)
< {
< ui_cancellation_request();
< }
---
> while(select(fd + 1, &read_ready, NULL, NULL, &ts) == 0 || errno == EINTR);
</source>

Unified diff format:

<source lang="diff">
$ diff --unified src/utils/utils_nix.c_ src/utils/utils_nix.c
--- src/utils/utils_nix.c_ 2014-07-28 19:39:36.406899060 +0300
+++ src/utils/utils_nix.c 2014-07-28 19:38:52.720898588 +0300
@@ -153,13 +153,7 @@
ts = ts_init;
FD_SET(fd, &read_ready);
}
- while(select(fd + 1, &read_ready, NULL, NULL, &ts) == 0);
-
- /* Inform other parts of the application that cancellation took place. */
- if(errno == EINTR)
- {
- ui_cancellation_request();
- }
+ while(select(fd + 1, &read_ready, NULL, NULL, &ts) == 0 || errno == EINTR);
}
int
</source>

@@ Line 5: / Line 5: @@
 ==== Advices on patch files ====
-When providing a patch please as a diff please consider the following (these are
+When providing a patch as a diff please consider the following (these are
 not strict rules, but it makes reviewing easier):
 # Use unified diff format.  See [[#Why_unified_diff|section below]] for reasons.

Providing a patch - Revision history

24.146.215.113 at 04:43, 10 November 2014

Xaizek: Initial version of the page